Checkstyle Results

The following document contains the results of Checkstyle 9.3 with /home/tim/dev/FakeSMTP/src/main/config/checkstyle/custom_checks.xml ruleset.

Summary

Files  Info  Warnings  Errors
9 0 0 12

Files

File  I  W  E
com/nilhcem/fakesmtp/FakeSMTP.java 0 0 2
com/nilhcem/fakesmtp/core/exception/AbstractPortException.java 0 0 1
com/nilhcem/fakesmtp/core/exception/InvalidHostException.java 0 0 1
com/nilhcem/fakesmtp/gui/info/NbReceivedLabel.java 0 0 3
com/nilhcem/fakesmtp/gui/info/StartServerButton.java 0 0 1
com/nilhcem/fakesmtp/gui/listeners/AboutActionListener.java 0 0 1
com/nilhcem/fakesmtp/gui/listeners/ExitActionListener.java 0 0 1
com/nilhcem/fakesmtp/gui/listeners/MainWindowListener.java 0 0 1
com/nilhcem/fakesmtp/model/UIModel.java 0 0 1

Rules

Category Rule Violations Severity
blocks EmptyBlock 1  Error
coding AvoidInlineConditionals 1  Error
design DesignForExtension 4  Error
imports AvoidStarImport 5  Error
modifier RedundantModifier 1  Error

Details

com/nilhcem/fakesmtp/FakeSMTP.java

Severity Category Rule Message Line
 Error imports AvoidStarImport Using the '.*' form of import should be avoided - javax.swing.*. 12
 Error imports AvoidStarImport Using the '.*' form of import should be avoided - java.awt.*. 13

com/nilhcem/fakesmtp/core/exception/AbstractPortException.java

Severity Category Rule Message Line
 Error modifier RedundantModifier Redundant 'public' modifier. 19

com/nilhcem/fakesmtp/core/exception/InvalidHostException.java

Severity Category Rule Message Line
 Error design DesignForExtension Class 'InvalidHostException' looks like designed for extension (can be subclassed), but the method 'getHost' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'InvalidHostException' final or making the method 'getHost' static/final/abstract/empty, or adding allowed annotation for the method. 24

com/nilhcem/fakesmtp/gui/info/NbReceivedLabel.java

Severity Category Rule Message Line
 Error imports AvoidStarImport Using the '.*' form of import should be avoided - javax.swing.*. 8
 Error imports AvoidStarImport Using the '.*' form of import should be avoided - java.awt.*. 9
 Error coding AvoidInlineConditionals Avoid inline conditionals. 86

com/nilhcem/fakesmtp/gui/info/StartServerButton.java

Severity Category Rule Message Line
 Error imports AvoidStarImport Using the '.*' form of import should be avoided - com.nilhcem.fakesmtp.core.exception.*. 13

com/nilhcem/fakesmtp/gui/listeners/AboutActionListener.java

Severity Category Rule Message Line
 Error design DesignForExtension Class 'AboutActionListener' looks like designed for extension (can be subclassed), but the method 'actionPerformed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AboutActionListener' final or making the method 'actionPerformed' static/final/abstract/empty, or adding allowed annotation for the method. 39

com/nilhcem/fakesmtp/gui/listeners/ExitActionListener.java

Severity Category Rule Message Line
 Error design DesignForExtension Class 'ExitActionListener' looks like designed for extension (can be subclassed), but the method 'actionPerformed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ExitActionListener' final or making the method 'actionPerformed' static/final/abstract/empty, or adding allowed annotation for the method. 26

com/nilhcem/fakesmtp/gui/listeners/MainWindowListener.java

Severity Category Rule Message Line
 Error design DesignForExtension Class 'MainWindowListener' looks like designed for extension (can be subclassed), but the method 'windowStateChanged' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MainWindowListener' final or making the method 'windowStateChanged' static/final/abstract/empty, or adding allowed annotation for the method. 53

com/nilhcem/fakesmtp/model/UIModel.java

Severity Category Rule Message Line
 Error blocks EmptyBlock Must have at least one statement. 54